Skip to content
This repository was archived by the owner on May 4, 2019. It is now read-only.

Remove a problematic test case that we do not want to support #249

Merged
merged 1 commit into from
May 4, 2017
Merged

Remove a problematic test case that we do not want to support #249

merged 1 commit into from
May 4, 2017

Conversation

ararslan
Copy link
Member

@ararslan ararslan commented May 4, 2017

Ref discussion in JuliaStats/StatsBase.jl#248

@ararslan ararslan requested a review from nalimilan May 4, 2017 19:55
nalimilan
nalimilan approved these changes May 4, 2017
View reviewed changes
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that it was a single isolated line tends to confirm that this "feature" wasn't really considered as important.

@ararslan
Copy link
Member Author

ararslan commented May 4, 2017

The fact that it was a single isolated line tends to confirm that this "feature" wasn't really considered as important.

Agreed. Especially because just below the behavior is shown to be correct when using the skipna argument, which is really what you'd want in that case anyway.

@ararslan ararslan merged commit 36be315 into master May 4, 2017
@ararslan ararslan deleted the aa/no-weird-testcase branch May 4, 2017 21:15
@nalimilan
Copy link
Member

nalimilan commented May 5, 2017 •
edited
Loading

I've just found out that the WeightsVec signature was relaxed on purpose in JuliaStats/StatsBase.jl#89. It's still not clear to me what's the use case. @simonster?

@nalimilan nalimilan mentioned this pull request May 19, 2017
Open
tkelman pushed a commit to tkelman/DataArrays.jl that referenced this pull request May 24, 2017
@ararslan @tkelman
Remove a problematic test case that we do not want to support (JuliaS…
1a4e104 
…tats#249)

(cherry picked from commit 36be315)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ararslan @nalimilan