-
Notifications
You must be signed in to change notification settings - Fork 194
Adding support for different weight vector types #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
a323fc9
Initial work on adding weight vector types with bias correction.
rofinn 457f919
Added corrected option to many stats methods.
rofinn 7cd959d
Fixed style issues.
rofinn d0653db
Added re-added `WeightVec` only as a deprecated type and deprecated `…
rofinn e886066
Cleaned up docstrings for weight bias methods (mostly latex equations).
rofinn 6710bcb
Updated the "default" bias correction code to iteratively compute the…
rofinn e662b9d
Updated `FrequecyWeights` to accept `Real`s
rofinn e7f2ce9
Removed some unnecessary v0.5 pre-release code and version checks.
rofinn 15d8100
Converted a ternary to an if statement to help with readability.
rofinn 520c061
Replaced all internal (and test) calls to `weights(...)` with `fweigh…
rofinn a23b8cb
Changed function name `bias` -> `cfactor`.
rofinn 25f69f3
Removed corrected flag from `skewness` and `kurtosis` and set default…
rofinn 096548c
Fixed 0.6 `abstract type ... end ` deprecation warnings using compat.
rofinn 616408d
Removed `corrected` option from `moment`s, but kept it for `_moment2`…
rofinn b73a00a
Renamed cfactor -> varcorrection
rofinn a9485db
Fixed comments in export.
rofinn 7f179ef
Fixed more style issues.
rofinn c9437ab
Reverted dispatching on corrected value.
rofinn 7072eae
Updated weights docstrings.
rofinn 46a1aa9
Reworked `var` and `std` definitions and doc strings.
rofinn e831d15
Removed a couple unnecessary functions from deprecates.
rofinn 4ade783
Updated mean_and_x docstrings to mention `corrected` and point to the…
rofinn 7bdc112
Added documentation about `corrected` argument in `cov` and `mean_and…
rofinn f6f3b38
Added deprecation tests and fixed a few bugs with our deprecations.
rofinn ad49920
Fixed analytic weights `varcorrection` equations.
rofinn def70e2
Added an extra deprecation test and fixed --depwarn=no check.
rofinn 06ec7f9
Updated test/moments.jl to use `@testset` so that we can test against…
rofinn 1765f67
Updated test/weights.jl to use `@testset` so that we can test against…
rofinn 4b42570
Updated test/cov.jl to use `@testset` and added a few extra tests.
rofinn dd9e94e
Switched positional corrected back to a keyword with `Union{Bool, Voi…
rofinn a627e01
Added generic `Weights` type and deprecated `WeightVec` to it.
rofinn 34c88f2
Removed eweights and fixed up test cases.
rofinn 1f01bc0
Added testing of all weights to test/cov.jl
rofinn bdec9e1
Removed unnecessary 0 mean condition from `var`
rofinn c0f6488
Reverted changes to skewness and kurtosis.
rofinn a8624cd
Updated docs to refer to `AbstractWeighs` vs `WeightVec` and included…
rofinn 745c419
More random fixes. Mostly to docstrings.
rofinn 8d85af7
More doc fixes.
rofinn 05a3cd7
Removed `fweights` from tests in favour of `weights` (to reduces PR s…
rofinn 2370595
Moved description of different weight types in an Implementations sec…
rofinn 3f84e71
Moved `Weights` description later in the docs.
rofinn 8bcf448
Removed two argument example from weightvec docs.
rofinn dedb155
Moved description of weight vector benefits to the top of the file.
rofinn 281654d
Not sure how much this helped, but tried to minimize the amount of `@…
rofinn 5bdf58b
Added comment about unsupported bias correction for the `Weights` typ…
rofinn b991667
Removed deprecation tests and corresponding hacks.
rofinn 926678e
Removed more deprecation test hacks and convert `wv` -> `w` in the ap…
rofinn 85ace2a
Missing depcheck on a `stdm` call.
rofinn a0a2ad6
Updated the rst scalarstats and cov docs with the updated docstrings.
rofinn 6087b7f
More rst docstring updates.
rofinn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
weightvec
still the right ReST reference?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I didn't rename the file. I assume that's what the
:ref:
is for (I really don't know restructured text though)?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that the link still works (it's just pointing to the weightvec.rst file).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for checking! I don't know how it works either. 🙃