Skip to content

Calendar => Dates #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2014
Merged

Calendar => Dates #11

merged 2 commits into from
Aug 25, 2014

Conversation

WestleyArgentum
Copy link
Collaborator

Improved version of #9

I'll probably try to do a more comprehensive update of the travis stuff as a separate PR, but this should work for now.

@quinnj
Copy link
Member

quinnj commented Aug 25, 2014

👍

@WestleyArgentum
Copy link
Collaborator Author

Alright, I'm going to merge this into master and try poke at the travis build - maybe soon after that we can tag a new release and make everyone getting ambiguity warnings a little happier. Thanks for putting that work into Dates.jl @quinnj!

WestleyArgentum added a commit that referenced this pull request Aug 25, 2014
@WestleyArgentum WestleyArgentum merged commit 506f5b0 into JuliaWeb:master Aug 25, 2014
@quinnj
Copy link
Member

quinnj commented Aug 25, 2014

No problem. Hopefully it's a good omen for the Dates parsing/formatting code that it was pretty easy to add this functionality! This is a great change though since we can avoid relying on ICU and building/getting the binary dependency though when we really only need a tiny piece of the functionality.

@IainNZ
Copy link
Contributor

IainNZ commented Aug 25, 2014

Hah, neat

@IainNZ
Copy link
Contributor

IainNZ commented Aug 25, 2014

Travis doesn't seem to be testing julia-release. Should do that, and can also use Pkg.test() now. I can do this @WestleyArgentum, let me know so we don't duplicate effort.

@WestleyArgentum
Copy link
Collaborator Author

Oh, if you want to, go for it @IainNZ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants