cxx-qt-gen: add support for multiple QObjects in writer/cpp #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
force-pushed
the
generate-phase-multiple-qobjects
branch
from
14828a8 to
4843bb2
Compare
|
This assumes that one module block will result in one C++ header file (which i believe will always be true?). Our other debates are whether the module or file name should be used for the resultant files, so then that would determine if multiple module blocks result in multiple C++ header files or a single header file. However for now we only support one module per file anyway (and also one QObject per module, but that may change sooner) |
|
For now this can be draft as the Rust side needs figuring out in the CXX bridge to avoid collisions. |
ahayzen-kdab
changed the title
|
See in #157 under "Support multiple QObject's being defined in one block" why the Rust side of this is blocked. |
ahayzen-kdab
force-pushed
the
generate-phase-multiple-qobjects
branch
from
4843bb2 to
96e0770
Compare
53 tasks
ahayzen-kdab
force-pushed
the
generate-phase-multiple-qobjects
branch
2 times, most recently
from
804b1e3 to
8fe9276
Compare
ahayzen-kdab
force-pushed
the
generate-phase-multiple-qobjects
branch
from
8fe9276 to
f220705
Compare
ahayzen-kdab
changed the title
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.