Skip to content

Allow token bearer authentication through environment variables #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

erdalsivri
Copy link
Contributor

No description provided.

@erdalsivri erdalsivri requested a review from stevemessick June 12, 2025 01:26
Copy link
Contributor

@stevemessick stevemessick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kapigen update?

)
exit(1)

def _authenticate_with_legacy_apikey(self) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None --> bool
since it does return something now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

if name in self.config_values:
return self.config_values[name]
return None
return self.config_values.get(name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, can't believe I didn't notice this!

@erdalsivri
Copy link
Contributor Author

erdalsivri commented Jun 12, 2025

kapigen update?

I did make kapigen updates in some branch but totally forgot about them. Will prepare a PR soon

@erdalsivri erdalsivri merged commit 092602e into main Jun 12, 2025
4 checks passed
@erdalsivri erdalsivri deleted the allow-token-auth branch June 12, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants