feat: Create checkbox UI Component #8419
Open
+55
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's wait until after v11 is shipped to merge additional changes, by the way. |
pavkout
force-pushed
the
feature/ins-5035
branch
from
f1f497e to
ccf38a8
Compare
pavkout
force-pushed
the
feature/ins-5035
branch
from
ccf38a8 to
31405e3
Compare
marckong
reviewed
Mar 18, 2025
| useEffect(() => { | ||
| if (checkRef.current) { | ||
| checkRef.current.checked = checked; | ||
| checkRef.current.indeterminate = indeterminate; |
There was a problem hiding this comment.
how do we handle indeterminate status with the new checkbox?
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/checkbox
There was a problem hiding this comment.
@marckong We never used this component.
marckong
reviewed
Mar 18, 2025
| children: React.ReactNode; | ||
| } & CheckboxProps; | ||
|
|
||
| export const Checkbox = ({ children, ...props }: Props) => { |
There was a problem hiding this comment.
We might want to pass a ref object here in case if it needs a handle to be controlled by its parent?
yaoweiprc
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes INS-5035