Skip to content

fix: merge existing baseEnvironment data and dataPropertyOrder on import #8584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

PhilKes
Copy link

@PhilKes PhilKes commented Apr 5, 2025

Fixes #6785

Currently when importing e.g. an OpenAPI YAML, the baseEnvironment is not updated correctly. Its data is overwritten (not merged with the existing data, which is very annoying) and the dataPropertyOrder is not updated correctly therefore leading to the issue described in #6785.

This PR:

  • Merges the existing baseEnvironment.data with baseEnvironmentFromResources.data on import
  • Correctly updates the baseEnvironment.dataPropertyOrder on import

@CLAassistant
Copy link

CLAassistant commented Apr 5, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@PhilKes PhilKes force-pushed the fix/import-merge-base-environment branch 2 times, most recently from 4218129 to 4a609a0 Compare April 9, 2025 15:38
@PhilKes PhilKes force-pushed the fix/import-merge-base-environment branch from 4a609a0 to 12978ba Compare April 13, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Between the 5/17 release and now OpenAPI import no longer creates Base Environment base_url variable
2 participants