Fix compilation after KT-76478 #4442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhalanskyjb
requested changes
May 22, 2025
| @@ -96,6 +96,7 @@ internal fun restoreThreadContext(context: CoroutineContext, oldState: Any?) { | |||
| @PublishedApi | |||
| internal data class ThreadLocalKey(private val threadLocal: ThreadLocal<*>) : CoroutineContext.Key<ThreadLocalElement<*>> | |||
|
|
|||
| @PublishedApi | |||
There was a problem hiding this comment.
Note: I wonder why this does not appear in the API dump.
There was a problem hiding this comment.
@fzhinkin, do you have an idea?
There was a problem hiding this comment.
@dkhalanskyjb that's because the internal package is explicitly excluded from dumps:
kotlinx.coroutines/build.gradle.kts
Line 77 in f4f519b
There was a problem hiding this comment.
Thank you! I didn't realize that was a thing. I think it's a mistake to exclude anything from the API dump at this point, but that's beyond the scope of this PR.
cypressious
force-pushed
the
fix-exposed-types
branch
from
49621c1 to
3608fc0
Compare
dkhalanskyjb
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.