Use generics for rows and columns #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the rows setting and instead uses generics for rows and columns.
This allows for asserts in some places to make sure the users aren't passing in values larger than the set rows or columns values.
With this support for screens up to 20x4 was added (I know the name of the library specifies 1602 but I don't think there is a point in not supporting them, it only cost some very small changes)
(I'm also currently preparing a PR to support the creating of new characters which the LCDs allow as well)