❗️❗️[NAGA] Develop Branch #776
Open
+24,675
−159,615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… usage - Also send `nodeSet` to `sign_session_key` endpoint as it is required - Fixed typo on name of wasm method for `ecdsaCombineAndVerify` (was previously unused)
…a-dev-support-with-rust-toolchain add rust-toolchain.toml so we autoinstall some necessary rust stuff
…a-add-naga-dev-support feat: add naga dev support
…ithub.com/LIT-Protocol/js-sdk into feature/lit-4124-js-sdk-naga-fix-bls-wasm
- **Added**: New file defining: - union type for cryptographic signature types. - interface for standardized HTTP responses. - Partial interface for raw ECDSA message data. - **Updated**: now exports all types from . **Implications**: - Enables consistent usage of HTTP response and signature types across the application. - Improves maintainability and type safety for API client implementations.
…les and internal documentation (#1234)<details><summary>Difference analysis</summary>Changes made:- Removed the import of `PKPSignShare`- Removed the export of `SuccessNodePromises` from types- Removed commented example output blocks- Removed an internal console.log statementThe changes are primarily cleanup and do not alter functionality.</details>
…esSignatureShares` as deprecated
- **Added**: Optional fields and to the interface. - **Updated**: Moved to a new position and made it optional (). - **Removed**: The original line was refactored for better structure. **Implications**: - Provides flexibility by allowing certain fields to be undefined or null. - Improves structure for handling edge cases or incomplete data in
…add `bls.spec.ts` unit tests
…essControlConditions`, and `validateAccessControlConditions` to `access-control-conditions` from `LitNodeClient`
…uth-helpers` from `LitNodeClient`
…uth-helpers` from `LitNodeClient`
…Chain` to `constants` package from `types` package to prevent circular dependency. (constants > schema > types)
removed: - setCustomBootstrapUrls() privatised: - _handshakeWithNode - _getRandomHexString - _sendCommandToNode - _getNodePromises - _getSessionSigByUrl - _handleNodePromises - _throwNodeError feature: - Added `EPOCH_READY_FOR_LOCAL_DEV` as constant with JsDoc
relocated: - generateSessionCapabilityObjectWithWildcards - validateAccessControlConditions - getHashedAccessControlConditions privatised: - _getWalletSig - _checkNeedToResignSessionKey - _getSessionSigByUrl - _sendCommandToNode - _signSessionKey
…a-housekeeping Feature/lit 4185 js sdk naga housekeeping
- Removed unused imports - Sorted imports
…ce-feed-info-manager` module - Only 1 fetch promise can be run at a time; concurrent requests chain on pending promises - Only fetches new data if it has been > 3 seconds since last fetch - Updated static method `getPriceFeedInfo()` on LitContracts class to use the manager so all consumers get this behaviour - Export the raw helper functions for consumption by other classes
…om LitCore/LitNodeClient; use price-feed-info-manager instead - Removed `nodePrices` array from `LitCore` config state; this would be redundant since we cache price feed info in the manager module now - Update `getMaxPricesForNodeProduct()` on `LitNodeClient` to be an async method, since it will sometimes fetch new prices - CHORE: Removed unused access control method imports from `lit-node-client-nodejs.ts` - CHORE: Removed duplicate `export * from...` in constants/index.ts - Added private `_getNodePrices()` method to LitNodeClient that calls the new `price-feed-info-manager` method w/ args from the current client config
LIT-4207 - Implement node price re-fetching when running lit node commands
Closed
… to also use zod and be integrated into the sdk instead of an external package using ajv
…o derive constants, types and params where applicable. This makes any lit supported chain update single source of truth
…-minimal-zod feat: add new schemas package using zod, bring acc validation package…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Compatability
Test
Command
E2E
BLS unit test
❗️NOTE
Everyone else/InternalDev will be on this 👉🏻
60318791258d273df8209b912b386680d25d0df3👈❌ It's NOT compatible with the latest commit in the
developbranch❌ This dose not work against
naga-dev- we need to update lit-contracts to re-deploy naga-dev abis❌ authSig (ETH, SOL, Cosmos) encryption/decryption does not work.