Skip to content

Anson/propose change for 788 #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

Anson/propose change for 788 #815

merged 1 commit into from
Apr 9, 2025
+184 −33

Conversation

Ansonhkg
Copy link
Collaborator

@Ansonhkg Ansonhkg commented Apr 9, 2025 •
edited
Loading

WHAT

fixes for #788

Test

bun test "./packages/crypto/src/lib/crypto.spec.ts" -t "walletEncrypt and walletDecrypt"
image

Note that it might not run in Jest due to environment differences maybe we need extra configurations for wasm loading or issue with jsdom? no time to figure that out sorry, hence i'm using Bun

@Ansonhkg Ansonhkg changed the base branch from master to ml/e2ee April 9, 2025 16:10
@Ansonhkg Ansonhkg mentioned this pull request Apr 9, 2025
Open
4 tasks
@Ansonhkg Ansonhkg merged commit 0f40949 into ml/e2ee Apr 9, 2025
1 check passed
@Ansonhkg Ansonhkg deleted the anson/propose-change-for-788 branch April 9, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedericoAmura FedericoAmura FedericoAmura approved these changes

@mikelodder7 mikelodder7 Awaiting requested review from mikelodder7

@MaximusHaximus MaximusHaximus Awaiting requested review from MaximusHaximus

@DashKash54 DashKash54 Awaiting requested review from DashKash54

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ansonhkg @FedericoAmura