-
Notifications
You must be signed in to change notification settings - Fork 28
Upgraded packaging infrastructure #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fyi to @LRWeber about this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may also want to delete requirements.txt
since it references the other deleted file.
Our automated testing action currently has the dev dependencies hardcoded. scraper/.github/workflows/main.yml Lines 34 to 37 in 9593f4a
Should it be using a different command to leverage the dependency list(s) in the .toml file (e.g. pip install .[dev] )? Or is it specifically using a minimal list? (And if that's the case, should that be another list defined in the .toml file?)
|
@LRWeber - good catches! I just updated the actions file to convert over to using the definition out of the pyproject.toml file instead. Good catch! |
Ref: