feat!: rewrite #4

EthanL06 · 2025-04-23T19:17:04Z

Entire rewrite of UTLP codebase.

Tech stack:

WXT
Solid.js
TypeScript
TailwindCSS
Corvu (Radix UI equivalent)

Major changes:

Bookmarks
AI Generated Summary
Custom Playback Rate
Design revamp
Download/Copy Transcript

All of the main code is under src/entrypoints.

src/entrypoints/main.content: contains everything related to the sidebar.
src/entrypoints/injected.content contains everything related to the injected CSS on the website.
src/entrypoints/popup contains everything related to popup
src/entrypoints/background.ts is the background script

Samathingamajig

a few things that jumped out to me

Samathingamajig · 2025-04-23T19:36:27Z

.gitignore

-*.sw?
+*.sw?


keep newline at the end of the file

Samathingamajig · 2025-04-23T19:42:01Z

eslint.config.js

-            '@typescript-eslint/explicit-function-return-type': [
-                'error',
-                {
-                    allowExpressions: true,
-                    allowTypedFunctionExpressions: true,
-                },
-            ],
+            // '@typescript-eslint/explicit-function-return-type': [
+            //     'error',
+            //     {
+            //         allowExpressions: true,
+            //         allowTypedFunctionExpressions: true,
+            //     },
+            // ],


why comment out when you could cut

Samathingamajig · 2025-04-23T19:42:42Z

package.json

-    "name": "ut-lectures-plus",
-    "description": "This plugin adds a transcript box (with search) to all LectureOnline and TowerLA lectures from UT Austin! Studying has never been easier.",
+    "name": "wxt-solid-starter",
+    "description": "manifest.json description",
    "private": true,
-    "version": "5.0.0",
-    "homepage": "https://github.com/Longhorn-Developers/UT-Lectures-Plus",
-    "license": "MIT",
+    "version": "0.0.0",


some of these things shouldn't've been changed

also, make sure the version is a major version bump from whatever was there previously

Samathingamajig · 2025-04-23T19:48:33Z

wxt.config.ts

 import { defineConfig } from 'wxt';

 // See https://wxt.dev/api/config.html
 export default defineConfig({
-    srcDir: 'src',


feels weird to not have a src directory, floods the upper level

Agreed, I also prefer having a src dir especially as we begin to populate this with dotfiles.

Samathingamajig · 2025-04-23T19:48:34Z

wxt.config.ts

    modules: ['@wxt-dev/module-solid'],
-    imports: false, // Disable auto-imports


do we really want autoimports?

Samathingamajig · 2025-04-23T19:49:15Z

wxt.config.ts

-        permissions: ['webRequest', 'tabs'],
+        name: 'UT Lectures Plus',
+        description: 'Enhance your UT Austin Lectures experience.',
+        permissions: ['webRequest', 'tabs', 'storage'],


tabs is a very powerful persmission, i think it will pop up with "read and modify data on all sites", do we really need the tabs permission?

We request the tabs permission because the extension needs to handle scenarios where users have multiple lecture video tabs open. Specifically, the background script uses the tabs API to:

Track which transcript corresponds to which tab

Sends transcripts to the correct active tab for display

You can see how this is being implemented here. If there's a better way to achieve this without using the tabs permission, I'd be happy to update it

actually nvm, figured it out lol

…SLint config

…of file

…and config

doprz · 2025-04-24T23:44:38Z

I've updated the PR title to indicate that it contains breaking changes.

doprz · 2025-04-24T23:47:16Z

@EthanL06 For such a big PR such as thsi one where you're rewriting most if not all of the codebase, please update your original comment to include the tech stack used and any other major changes you've made please.

doprz

Please refer to my previous comments in addition to updating README.md.
I will be performing a more detailed PR review soon.

Samathingamajig · 2025-04-26T07:09:11Z

src/entrypoints/main.content/index.tsx

+            setTimeout(() => {
+                const container = document.querySelector('.video-js') as HTMLElement;
+                if (container) {
+                    const video = container.querySelector('video');
+
+                    if (!video) {
+                        console.error('Video element not found');
+                        return;
+                    }
+
+                    console.warn('🎥 Video found on fallback!');
+                    observer.disconnect();
+
+                    container.style.borderRadius = '1rem';
+                    container.style.backgroundColor = 'oklch(98.4% 0.003 247.858)';
+                    container.style.overflow = 'hidden';
+
+                    video.style.borderRadius = '1rem';
+
+                    setVideoElement(video);
+                }
+            }, 5000); // fallback after 5 seconds


You may want to clear this timeout if the mutation observer finds the video before the 5 seconds goes off

Samathingamajig · 2025-04-26T07:10:36Z

src/entrypoints/main.content/index.tsx

+                    container.style.borderRadius = '1rem';
+                    container.style.backgroundColor = 'oklch(98.4% 0.003 247.858)';
+                    container.style.overflow = 'hidden';
+
+                    video.style.borderRadius = '1rem';


The style stuff here is duplicated above... also, in this section you don't set the videoContainer.style.boxShadow, but you do above. Having a single function used in both places would reduce the duplication and the risk of missing a change in one place

…ound script with tabs permission

doprz · 2025-04-28T16:54:37Z

package.json

-    "homepage": "https://github.com/Longhorn-Developers/UT-Lectures-Plus",
-    "license": "MIT",


I would add this back in

doprz · 2025-04-28T16:56:35Z

src/entrypoints/background.ts

+
+    const addVTTListener = () => {
+        if (!isListenerActive) {
+            browser.webRequest.onBeforeRequest.addListener(requestListener, { urls: ['*://*.la.utexas.edu/*'] }, [


Not a big fan of hardcoding this in. Let's extract this into a const object.

doprz · 2025-04-28T16:58:22Z

wxt.config.ts

    manifest: {
-        permissions: ['webRequest', 'tabs'],
+        name: 'UT Lectures Plus',
+        description:
+            'This plugin adds a transcript box (with search) to all LectureOnline and TowerLA lectures from UT Austin! Studying has never been easier.',


Would be a good idea to import this from package.json

doprz · 2025-04-28T17:00:23Z

@EthanL06 , just left some nit comments but we can fix the nit things now or in the future as they don't affect functionality, up to you. Overall great job with this rewrite!

@Samathingamajig this PR LGTM once the comments/feedback have been addressed so that we can start creating issues and PRs that depend on this PR.

EthanL06 · 2025-05-03T22:34:19Z

Todo:

Keyboard shortcuts
Add "No Transcript Available" when no captions
HH:MM:SS
Specify URLs better

init

a604700

EthanL06 requested a review from doprz April 23, 2025 19:17

Samathingamajig requested changes Apr 23, 2025

View reviewed changes

EthanL06 added 6 commits April 23, 2025 16:53

feat: update package name and description for clarity

e885d36

fix: remove commented-out rule for explicit function return type in E…

b266473

…SLint config

fix: ensure proper formatting in .gitignore by adding newline at end …

99fd9d1

…of file

fix: remove redundant comment on auto-imports in wxt.config.ts

e9ea5ac

feat: switch to src directory

c1daf79

fix: update connection handling and permissions in background script …

bc0e21a

…and config

EthanL06 requested a review from Samathingamajig April 23, 2025 22:21

doprz assigned EthanL06 Apr 24, 2025

doprz changed the title ~~feat: rewrite~~ feat!: rewrite Apr 24, 2025

doprz added the enhancement New feature or request label Apr 24, 2025

doprz requested a review from a team April 24, 2025 23:47

doprz requested changes Apr 24, 2025

View reviewed changes

EthanL06 added 4 commits April 26, 2025 01:06

fix: update content script match patterns for specific routes

0f3ed34

fix: enhance styling and add sidebar state management in App component

6aff910

feat: add clipboard functionality to copy transcript from VTT

b5385e3

fix: remove autofill password for api key input

d811eb3

Samathingamajig reviewed Apr 26, 2025

View reviewed changes

fix: same transcript appears on multiple lectures by reverting backgr…

6a092bb

…ound script with tabs permission

doprz requested changes Apr 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: rewrite #4

feat!: rewrite #4

EthanL06 commented Apr 23, 2025 •

edited

Loading

Samathingamajig left a comment

Samathingamajig Apr 23, 2025

Samathingamajig Apr 23, 2025

Samathingamajig Apr 23, 2025

Samathingamajig Apr 23, 2025

doprz Apr 24, 2025

Samathingamajig Apr 23, 2025

Samathingamajig Apr 23, 2025

EthanL06 Apr 23, 2025

EthanL06 Apr 23, 2025

doprz commented Apr 24, 2025

doprz commented Apr 24, 2025

doprz left a comment

Samathingamajig Apr 26, 2025

Samathingamajig Apr 26, 2025

doprz Apr 28, 2025

doprz Apr 28, 2025

doprz Apr 28, 2025

doprz commented Apr 28, 2025

EthanL06 commented May 3, 2025

		modules: ['@wxt-dev/module-solid'],
		imports: false, // Disable auto-imports

		"homepage": "https://github.com/Longhorn-Developers/UT-Lectures-Plus",
		"license": "MIT",

		*.sw?
		*.sw?

feat!: rewrite #4

Are you sure you want to change the base?

feat!: rewrite #4

Conversation

EthanL06 commented Apr 23, 2025 • edited Loading

Samathingamajig left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

doprz commented Apr 24, 2025

doprz commented Apr 24, 2025

doprz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

doprz commented Apr 28, 2025

EthanL06 commented May 3, 2025

EthanL06 commented Apr 23, 2025 •

edited

Loading