Implement arbitrary suffixes (for all literals) #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just two methods and two trait impls for `IntegerType` and `FloatType`
This is quite a big change. Its main motivation is to allow for
arbitrary suffixes, as allowed by the grammar (e.g. `23px`). This
required the following changes:
- Replace method `type_suffix` by `suffix(&self) -> &str`. Users are
expected to use `{Integer|Float}Type::from_suffix` to get the type.
- Change parsing to accept any suffix.
- Add function to check a suffix for validity.
- Change `Literal::parse` to only attempt to parse a float literal if it
contains a fractional or exponent part. This is a breaking behavior
change as previously `0f32` was parsed as float literal.
- `FloatLit::parse` now rejects integer literals like `23` or `23f32`.
- Adjusting all tests
This gets rid of a bit of duplication and might improve compile times (for the downstream crate) as all string parsing functions are now compiled once (without generics).
This improves the rendered docs.
LukasKalbertodt
force-pushed
the
arbitrary-suffixes
branch
from
ebefefe to
83816a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2
Quite a few breaking changes due to this change. This should fix the last known difference between litrs and the Rust compiler.