Skip to content

Multicomponent diffusion fluxes, thermal conduction, and mixture viscosity #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

DimAdam-01
Copy link
Contributor

@DimAdam-01 DimAdam-01 commented Jun 16, 2025

Description

Please include a summary of the changes and the related issue(s) if they exist.

This update implements the diffusive fluxes for chemical species, includes thermal conduction in the energy equation, and computes the mixture’s viscosity

Please also include relevant motivation and context.

Fixes #(issue) [optional]

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Something else

Scope

  • This PR comprises a set of related changes with a common goal

If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • This test examines one-dimensional multicomponent diffusion of four distinct species, as detailed in DOI 10.2514/6.2020-1751.
image image
  • Test B examines a two-dimensional premixed flame with an imposed perturbation, then tracks the ensuing thermo-diffusive instability growth.
image image

Test Configuration:

  • What computers and compilers did you use to test this:

My Laptop, Delta (A100) and Delta AI (GH)

Checklist

  • I have added comments for the new code
  • I added Doxygen docstrings to the new code
  • I have made corresponding changes to the documentation (docs/)
  • I have added regression tests to the test suite so that people can verify in the future that the feature is behaving as expected
  • I have added example cases in examples/ that demonstrate my new feature performing as expected.
    They run to completion and demonstrate "interesting physics"
  • I ran ./mfc.sh format before committing my code
  • New and existing tests pass locally with my changes, including with GPU capability enabled (both NVIDIA hardware with NVHPC compilers and AMD hardware with CRAY compilers) and disabled
  • This PR does not introduce any repeated code (it follows the DRY principle)
  • I cannot think of a way to condense this code and reduce any introduced additional line count

If your code changes any code source files (anything in src/simulation)

To make sure the code is performing as expected on GPU devices, I have:

  • Checked that the code compiles using NVHPC compilers
  • Checked that the code compiles using CRAY compilers
  • Ran the code on either V100, A100, or H100 GPUs and ensured the new feature performed as expected (the GPU results match the CPU results)
  • Ran the code on MI200+ GPUs and ensure the new features performed as expected (the GPU results match the CPU results)
  • Enclosed the new feature via nvtx ranges so that they can be identified in profiles
  • Ran a Nsight Systems profile using ./mfc.sh run XXXX --gpu -t simulation --nsys, and have attached the output file (.nsys-rep) and plain text results to this PR
  • Ran a Rocprof Systems profile using ./mfc.sh run XXXX --gpu -t simulation --rsys --hip-trace, and have attached the output file and plain text results to this PR.
  • Ran my code using various numbers of different GPUs (1, 2, and 8, for example) in parallel and made sure that the results scale similarly to what happens if you run without the new code/feature

@DimAdam-01 DimAdam-01 changed the title Diffusion for Chemistry Multicomponent diffusion fluxes, thermal conduction, and mixture viscosity Jun 16, 2025
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 5.88235% with 144 lines in your changes missing coverage. Please review.

Project coverage is 45.42%. Comparing base (2aad1d4) to head (59ca1c7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/common/m_chemistry.fpp 0.00% 59 Missing ⚠️
src/simulation/m_rhs.fpp 13.84% 49 Missing and 7 partials ⚠️
src/simulation/m_riemann_solvers.fpp 0.00% 26 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #888      +/-   ##
==========================================
- Coverage   45.76%   45.42%   -0.34%     
==========================================
  Files          68       68              
  Lines       18668    18798     +130     
  Branches     2251     2266      +15     
==========================================
- Hits         8543     8539       -4     
- Misses       8767     8892     +125     
- Partials     1358     1367       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants