Restart stale watch threads where they left off #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
restart_stale_watch_threads
branch
2 times, most recently
from
47e6ec6 to
82855bc
Compare
If a watch thread fails for any reason (exception, timeout, etc...) restart it with the last resourceVersion so it picks up where it left off.
agrare
force-pushed
the
restart_stale_watch_threads
branch
from
82855bc to
34a4a0a
Compare
|
Checked commit agrare@34a4a0a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@cben going from your linked comment kubernetes/website#6540 (comment) I'm setting the collection resourceVersion to the latest notice.object's resourceVersion. Does this look like a valid approach? |
cben
reviewed
Aug 23, 2018
| # object's resourceVersion so that if this watch has to be restarted | ||
| # it will pick up where it left off. | ||
| resource_version = notice.object.metadata.resourceVersion | ||
| resource_versions[entity_type] = resource_version |
There was a problem hiding this comment.
this updates a shared hash (at distinct keys) from multiple threads, is that fully safe in ruby?
There was a problem hiding this comment.
Yeah I'll use a Concurrent::Hash to be safe
|
Merging. I'll be on vacation all next week so will try to unblock as much stuff as possible today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a watch thread fails for any reason (exception, timeout, etc...)
restart it with the last resourceVersion so it picks up where it left
off.