Skip to content

Fix Bug with Introducers in Successions #4258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions manim/animation/composition.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,7 @@ def __init__(
self.rate_func = rate_func
self.group = group
if self.group is None:
mobjects = remove_list_redundancies(
[anim.mobject for anim in self.animations if not anim.is_introducer()],
)
mobjects = self._get_unintroduced_mobjects()
if config["renderer"] == RendererType.OPENGL:
self.group = OpenGLGroup(*mobjects)
else:
Expand All @@ -78,6 +76,11 @@ def __init__(
)
self.run_time: float = self.init_run_time(run_time)

def _get_unintroduced_mobjects(self) -> Sequence[Mobject]:
return remove_list_redundancies(
[anim.mobject for anim in self.animations if not anim.is_introducer()],
)

def get_all_mobjects(self) -> Sequence[Mobject]:
return list(self.group)

Expand Down Expand Up @@ -231,6 +234,16 @@ def construct(self):
def __init__(self, *animations: Animation, lag_ratio: float = 1, **kwargs) -> None:
super().__init__(*animations, lag_ratio=lag_ratio, **kwargs)

def _get_unintroduced_mobjects(self) -> Sequence[Mobject]:
introduced_mobjects = set()
unintroduced_mobjects = []
for anim in self.animations:
if anim.is_introducer():
introduced_mobjects.add(anim.mobject)
elif anim.mobject not in introduced_mobjects:
unintroduced_mobjects.append(anim.mobject)
return remove_list_redundancies(unintroduced_mobjects)

def begin(self) -> None:
if not self.animations:
raise ValueError(
Expand Down