Skip to content

Fixing files with few typing (mypy) errors #4263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

henrikmidtiby
Copy link
Contributor

Overview: What does this pull request change?

In this pull request I have addressed some of the files with only a few reported mypy errors.

Further Information and Comments

To identify files with few mypy errors, I cleared the mypy.ini file so no detected errors would be ignored and then used the follwing command

uv run pre-commit run mypy --all-files | grep "error" | sed 's/:.*//' | uniq -c | sort -n -r

I hope that this approach will make it easier to deal with the large files that needs a lot of type annotations added.

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

1 participant