-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix: AnimationGroup with negative z_index #4268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Comments from a regular developer here. I have tested the PR and it does indeed fix the problems reported in issue #3334 and #3914. The code that have been removed calls the method It would be nice to see if this change impacts the rendering speed for scenes with many static objects. |
Status of the PR as I see it right now.
The test failures occur in these tests
All tests fail the same way, with a message like this.
To see how the rendered scenes differ from the expected output test tests were run with this command
This generated a number of pdf files showing the actual output, the expected output and the difference. |
Thank you for the feedback. Now I have some problems with tests. I will try to fix them |
Overview: What does this pull request change?
Fixes an AnimationGroup behaviour with negative z_index Mobjects. More about this problem you can see in these issues:
#3334 and #3914
Motivation and Explanation: Why and how do your changes improve the library?
Mobjects with negative z_index have problems with playing in animations. This PR fixes it
Links to added or changed documentation pages
There are no changes to the documentation
Further Information and Comments
These changes initially caused some issues with graphical tests. In a few cases, there were minor pixel differences, so I slightly changed some of the tests to account for this
Reviewer Checklist