Skip to content

Set up deployment pipeline for mz-debug #32117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 10, 2025
Merged

Conversation

SangJunBak
Copy link
Contributor

@SangJunBak SangJunBak commented Apr 7, 2025

Based on PR #32122

Chain of upstream PRs as of 2025-04-08

See commit messages for details

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@SangJunBak SangJunBak changed the base branch from main to jun/#8908/polish April 7, 2025 19:40
@SangJunBak SangJunBak changed the title Separate emulator and self-managed sub-commands Set up deployment pipeline for mz-debug Apr 7, 2025
@SangJunBak SangJunBak force-pushed the jun/#8908/deploy-debug-tool branch from c1a3111 to bc4b8c2 Compare April 7, 2025 19:41
@SangJunBak SangJunBak changed the base branch from jun/#8908/polish to main April 7, 2025 19:42
@SangJunBak SangJunBak force-pushed the jun/#8908/deploy-debug-tool branch 2 times, most recently from 60975fd to f393375 Compare April 8, 2025 17:23
@SangJunBak SangJunBak marked this pull request as ready for review April 8, 2025 17:37
@SangJunBak SangJunBak requested a review from a team as a code owner April 8, 2025 17:38
@SangJunBak SangJunBak requested a review from def- April 8, 2025 17:38
@SangJunBak SangJunBak changed the base branch from main to jun/#8908/clap-fixes April 8, 2025 17:38
@SangJunBak SangJunBak force-pushed the jun/#8908/clap-fixes branch from 937d857 to b95a37a Compare April 8, 2025 17:45
@SangJunBak SangJunBak force-pushed the jun/#8908/deploy-debug-tool branch from 9fe5a40 to 5ba7fb7 Compare April 8, 2025 17:46
@SangJunBak SangJunBak force-pushed the jun/#8908/clap-fixes branch from b95a37a to 0726fc1 Compare April 8, 2025 17:52
@SangJunBak SangJunBak force-pushed the jun/#8908/deploy-debug-tool branch from 5ba7fb7 to 2e630f3 Compare April 8, 2025 17:53
@SangJunBak SangJunBak force-pushed the jun/#8908/clap-fixes branch from 0726fc1 to a6d2ad7 Compare April 8, 2025 19:18
@SangJunBak SangJunBak force-pushed the jun/#8908/deploy-debug-tool branch from 2e630f3 to 3846c6c Compare April 8, 2025 19:18
@SangJunBak SangJunBak force-pushed the jun/#8908/clap-fixes branch from a6d2ad7 to 6bed857 Compare April 8, 2025 20:45
@SangJunBak SangJunBak force-pushed the jun/#8908/deploy-debug-tool branch 3 times, most recently from e5c79da to 1e1b601 Compare April 8, 2025 20:54
Base automatically changed from jun/#8908/clap-fixes to main April 8, 2025 21:44
@@ -0,0 +1,20 @@
# Deploy the Materialize debug tool.

The CI process will build and deploy the LSP server to the materialize-binaries S3 bucket.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LSP server?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 my bad!

c.up("materialized")

# Get the container id of the materialized service
print(c.container_id("materialized"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug printing?

@@ -0,0 +1 @@
eyJ0eXAiOiJKV1QiLCJhbGciOiJQUzI1NiJ9.eyJzdWIiOiIwMDAwMDAwMC0wMDAwLTAwMDAtMDAwMC0wMDAwMDAwMDAwMDAiLCJleHAiOjIwNTg5NzQ2ODgsIm5iZiI6MTc0MzYxNDY4OCwiaXNzIjoiTWF0ZXJpYWxpemUsIEluYy4iLCJhdWQiOiIwMDAwMDAwMC0wMDAwLTAwMDAtMDAwMC0wMDAwMDAwMDAwMDAiLCJpYXQiOjE3NDM2MTQ2ODgsImp0aSI6ImVkZGFmMDA0LWRjMWUtNDhjZi05Y2MxLTQxZDE1NDNkOTQwYSIsInZlcnNpb24iOjEsIm1heF9jcmVkaXRfY29uc3VtcHRpb25fcmF0ZSI6MTAwMC4wLCJhbGxvd19jcmVkaXRfY29uc3VtcHRpb25fb3ZlcnJpZGUiOnRydWUsImV4cGlyYXRpb25fYmVoYXZpb3IiOiJXYXJuIn0.a-O0xEfwgKKWkKCUoKF_odY_-ZbMN8t-fkLLfVvYkprD-uI2mFtWwVup9rRNDPdXO6M4aDkmTuTaX5Wt9jv1pPHDicICqPITtwCisvVRzV4IRcP09DinN-vooTcQy-ehG4smlpZ3CpWdig3CiJI4Sjv_QMTr6G8ETslZHCAtUfNpglSDXDCIBBujmiAQB6LpgTzNV6Uuq6t-FPKGAfhs3NkxSV_KGm-4LcoqhrqiLv6IotanwTTf7ZUeyW0HApdTbfFw6oBh_RORFULHcLojI8n5kAy2VIqzgc_ft2EpFNsw_L0XqhvECIfr-6f1oXErD7YdXNuEC2jdfWnapg3k7i61IbHyU6bo35tNw3AFynsx29UeeClmHdYW_UsyZAQmwjvW3pFo9Itaz1v9cVggZew_pa-tt6qXVvr9T6MnCbjj-zxJhAWyR4vRms817t4VgqHW9paa9l9aw4adWAkpzK3W0D1U0_lsCM-_918znZkmn0c7WxAFHAvjxob9d1xcJna06grsmzvCcFdtdlveqZB-s4nxDAB5rM5rm6vrLBf81x8UCuwA76NJxAmSXvKpVqS7iet_Crow90UPCOUoxWl2ql6HUXqVj4dl7nS43v42rFZGonjE4pL-A-7QYXfoqly0LoR-kCeBwHpKGJtDzBYBRl14-YGjH-y9HfOvBkI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, I think we have to invalidate and recreate this key now for everyone. CC @doy-materialize
I'll add license_key to .gitignore so this doesn't happen so easily again.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which key is this? (where did it come from?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the materialize dev license key in 1password.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SangJunBak SangJunBak force-pushed the jun/#8908/deploy-debug-tool branch from 7366895 to 1ee28f5 Compare April 9, 2025 14:47
@SangJunBak SangJunBak requested a review from def- April 9, 2025 14:47
- I refactored mz_lsp_server's deploy_utils into a tarball_uploader. I plan to move the other binaries to use it too.
- Tested macos and linux separately
- Unclear if deploy_utils is necessary or if I should rename it. Not confident on where each variable lives as well.
- Created a binary to run mz-debug
- Implements cloud test and mzcompose test that checks if the tool generates a zip, which is a sign of success.
@def- def- force-pushed the jun/#8908/deploy-debug-tool branch from ecaaefe to 829447a Compare April 10, 2025 00:16
@SangJunBak SangJunBak merged commit 60490ed into main Apr 10, 2025
86 checks passed
@SangJunBak SangJunBak deleted the jun/#8908/deploy-debug-tool branch April 10, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants