-
Notifications
You must be signed in to change notification settings - Fork 470
Set up deployment pipeline for mz-debug #32117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c1a3111
to
bc4b8c2
Compare
60975fd
to
f393375
Compare
937d857
to
b95a37a
Compare
9fe5a40
to
5ba7fb7
Compare
b95a37a
to
0726fc1
Compare
5ba7fb7
to
2e630f3
Compare
0726fc1
to
a6d2ad7
Compare
2e630f3
to
3846c6c
Compare
a6d2ad7
to
6bed857
Compare
e5c79da
to
1e1b601
Compare
ci/deploy_mz-debug/README.md
Outdated
@@ -0,0 +1,20 @@ | |||
# Deploy the Materialize debug tool. | |||
|
|||
The CI process will build and deploy the LSP server to the materialize-binaries S3 bucket. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LSP server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 my bad!
test/mz-debug/mzcompose.py
Outdated
c.up("materialized") | ||
|
||
# Get the container id of the materialized service | ||
print(c.container_id("materialized")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug printing?
test/mz-debug/license_key
Outdated
@@ -0,0 +1 @@ | |||
eyJ0eXAiOiJKV1QiLCJhbGciOiJQUzI1NiJ9.eyJzdWIiOiIwMDAwMDAwMC0wMDAwLTAwMDAtMDAwMC0wMDAwMDAwMDAwMDAiLCJleHAiOjIwNTg5NzQ2ODgsIm5iZiI6MTc0MzYxNDY4OCwiaXNzIjoiTWF0ZXJpYWxpemUsIEluYy4iLCJhdWQiOiIwMDAwMDAwMC0wMDAwLTAwMDAtMDAwMC0wMDAwMDAwMDAwMDAiLCJpYXQiOjE3NDM2MTQ2ODgsImp0aSI6ImVkZGFmMDA0LWRjMWUtNDhjZi05Y2MxLTQxZDE1NDNkOTQwYSIsInZlcnNpb24iOjEsIm1heF9jcmVkaXRfY29uc3VtcHRpb25fcmF0ZSI6MTAwMC4wLCJhbGxvd19jcmVkaXRfY29uc3VtcHRpb25fb3ZlcnJpZGUiOnRydWUsImV4cGlyYXRpb25fYmVoYXZpb3IiOiJXYXJuIn0.a-O0xEfwgKKWkKCUoKF_odY_-ZbMN8t-fkLLfVvYkprD-uI2mFtWwVup9rRNDPdXO6M4aDkmTuTaX5Wt9jv1pPHDicICqPITtwCisvVRzV4IRcP09DinN-vooTcQy-ehG4smlpZ3CpWdig3CiJI4Sjv_QMTr6G8ETslZHCAtUfNpglSDXDCIBBujmiAQB6LpgTzNV6Uuq6t-FPKGAfhs3NkxSV_KGm-4LcoqhrqiLv6IotanwTTf7ZUeyW0HApdTbfFw6oBh_RORFULHcLojI8n5kAy2VIqzgc_ft2EpFNsw_L0XqhvECIfr-6f1oXErD7YdXNuEC2jdfWnapg3k7i61IbHyU6bo35tNw3AFynsx29UeeClmHdYW_UsyZAQmwjvW3pFo9Itaz1v9cVggZew_pa-tt6qXVvr9T6MnCbjj-zxJhAWyR4vRms817t4VgqHW9paa9l9aw4adWAkpzK3W0D1U0_lsCM-_918znZkmn0c7WxAFHAvjxob9d1xcJna06grsmzvCcFdtdlveqZB-s4nxDAB5rM5rm6vrLBf81x8UCuwA76NJxAmSXvKpVqS7iet_Crow90UPCOUoxWl2ql6HUXqVj4dl7nS43v42rFZGonjE4pL-A-7QYXfoqly0LoR-kCeBwHpKGJtDzBYBRl14-YGjH-y9HfOvBkI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch, I think we have to invalidate and recreate this key now for everyone. CC @doy-materialize
I'll add license_key to .gitignore so this doesn't happen so easily again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which key is this? (where did it come from?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the materialize dev license key in 1password.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7366895
to
1ee28f5
Compare
- I refactored mz_lsp_server's deploy_utils into a tarball_uploader. I plan to move the other binaries to use it too. - Tested macos and linux separately - Unclear if deploy_utils is necessary or if I should rename it. Not confident on where each variable lives as well. - Created a binary to run mz-debug
Fix lint errors Fix lint errors
- Implements cloud test and mzcompose test that checks if the tool generates a zip, which is a sign of success.
ecaaefe
to
829447a
Compare
Based on PR #32122
Chain of upstream PRs as of 2025-04-08
PR Fix interface bugs for mz-debug #32122:
main
←jun/#8908/clap-fixes
jun/#8908/clap-fixes
←jun/#8908/deploy-debug-tool
See commit messages for details
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.