Skip to content

More binary funcs using the proc macro #32170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

antiguru
Copy link
Member

@antiguru antiguru commented Apr 11, 2025

Convert more binary functions to the proc macro.

Part of MaterializeInc/database-issues#9138

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru antiguru marked this pull request as ready for review April 14, 2025 07:26
@antiguru antiguru requested a review from a team as a code owner April 14, 2025 07:26
@antiguru antiguru requested a review from ggevay April 14, 2025 07:26
Copy link
Contributor

@ggevay ggevay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antiguru antiguru merged commit efb9549 into MaterializeInc:main Apr 14, 2025
83 checks passed
@antiguru antiguru deleted the more_sqlfunc branch April 14, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants