Add support for extra environmentd env vars and args #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubrad
approved these changes
May 16, 2025
variables.tf
Outdated
Comment on lines
124
to
128
| environmentd_extra_env = optional(list(object({ | ||
| name = string | ||
| value = string | ||
| })), []) | ||
| environmentd_extra_args = optional(list(string), []) |
There was a problem hiding this comment.
I think we should provide some example for using this?
There was a problem hiding this comment.
Yes! I was also thinking about this, do you have any specific args in mind that you would like us to showcase in the examples?
There was a problem hiding this comment.
Just added some more info about the new options in the readme file, let me know what you think! Open to suggestions on the specific values!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to: MaterializeInc/terraform-aws-materialize#66