-
Notifications
You must be signed in to change notification settings - Fork 8
Add RMST test #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RMST test #188
Conversation
The current
By mimic the
Any suggestions/comments? References: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I rearranged the order of functions in rmst.R
to put the exported functions first and then followed the call sequence, as recommended by the tidyverse style guide:
In a file that contains multiple functions, public functions and their documentation should appear first, with private functions appearing after all documented functions.
Can you please fix the following (small) issues before we merge? Thanks.
df
is defined inone_rmst()
but not actually used. Can this be removed or is it intended to be used?- The description of "A list of 3 data frames of RMST calculations (
RMST
,RMSTDIFF
,ALL
)" does not match the implementation. - What does the "std" mean in "Variance, std, and CIs of the estimated RMST"? Maybe rephrase to make it clear.
…mes of RMST calculations (RMST, RMSTDIFF, ALL)" does not match the implementation."
Hello @nanxstats , thank you for these valuable comments! I have addressed them in my latest commits. Please take a moment to review them and let me know if they are clear to you. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LittleBeannie Looking great! Let's merge this 😎
Closes #16