Skip to content

Parameterize SmartTransactionsController state by ChainId for MultiChain + Integrate PollingController Mixin #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Oct 19, 2023
Merged

Parameterize SmartTransactionsController state by ChainId for MultiChain + Integrate PollingController Mixin #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
3ae0555
integrating multichain controller upgrades
adonesky1 Oct 11, 2023
bcab24b
add test
adonesky1 Oct 13, 2023
b7d2bb4
cleanup
adonesky1 Oct 13, 2023
e81084b
need to move confirmSmartTransaction tests into another test since co…
adonesky1 Oct 13, 2023
cb5585f
actually for now leave it as a public method
adonesky1 Oct 13, 2023
fb70480
cleanup
adonesky1 Oct 13, 2023
c34e0b3
fix typeerror?
adonesky1 Oct 13, 2023
34a90c7
add test + cleanup
adonesky1 Oct 16, 2023
1a1bcbf
add a test + bump test coverage
adonesky1 Oct 16, 2023
80b6a6a
update type
adonesky1 Oct 16, 2023
b591046
fix type issue
adonesky1 Oct 16, 2023
d644c5c
address feedback
adonesky1 Oct 16, 2023
311c991
fix provider logic
adonesky1 Oct 17, 2023
3843416
update test coverage threshholds
adonesky1 Oct 17, 2023
684bc59
make a private and public version of updateSmartTransaction
adonesky1 Oct 17, 2023
02af694
fix capitalization"
adonesky1 Oct 17, 2023
ec52211
addressing feedback
adonesky1 Oct 18, 2023
fe9732c
replace @ethersproject/providers with @metamask/eth-query
adonesky1 Oct 18, 2023
76faad0
cleanup
adonesky1 Oct 18, 2023
94e2fac
address more feedback
adonesky1 Oct 18, 2023
5fddb8d
remove @ethersproject/bignumber
adonesky1 Oct 18, 2023
99fc2cc
make confirmSmartTransaction a private method
adonesky1 Oct 18, 2023
2ee91e5
remove comment
adonesky1 Oct 18, 2023
9c4a772
getTransaction -> getTransactionByHash
adonesky1 Oct 19, 2023
c74619c
fix ethquery mock
adonesky1 Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ module.exports = {
coverageReporters: ['text', 'html'],
coverageThreshold: {
global: {
branches: 77,
functions: 89,
lines: 92,
statements: 91,
branches: 76.5,
functions: 92.5,
lines: 93.35,
statements: 93.35,
},
},
moduleFileExtensions: ['js', 'json', 'jsx', 'ts', 'tsx', 'node'],
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@
"test:watch": "jest --watchAll"
},
"dependencies": {
"@ethersproject/bignumber": "^5.7.0",
"@ethersproject/bytes": "^5.7.0",
"@ethersproject/providers": "^5.7.0",
"@metamask/base-controller": "^3.2.1",
"@metamask/controller-utils": "^5.0.0",
"@metamask/eth-query": "^3.0.1",
"@metamask/network-controller": "^15.0.0",
"@metamask/polling-controller": "^0.2.0",
"bignumber.js": "^9.0.1",
"fast-json-patch": "^3.1.0",
"lodash": "^4.17.21"
Expand Down
Loading