Perform semver-incompatible dependency updates; squash CI warnings #947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11882144096Details
💛 - Coveralls |
bgilbert
changed the title
A manual audit of the existing expr specifiers didn't turn up any problems with just switching to the 2024 semantics. https://doc.rust-lang.org/nightly/edition-guide/rust-2024/macro-fragment-specifiers.html
Inform Clippy of our minimum supported Rust version, so it won't advise us
to use #[expect] (which is too new).
We don't support older Rust because of cargo:: syntax in build.rs:
error: the `cargo::` syntax for build script output instructions was added in Rust 1.77.0, but the minimum supported Rust version of `git-interactive-rebase-tool v2.4.1 (/home/bgilbert/sw/git-interactive-rebase-tool)` is 1.56.0.
Switch to the old `cargo:rustc-check-cfg=cfg(allow_unknown_lints)` syntax (note the single colon).
See https://doc.rust-lang.org/cargo/reference/build-scripts.html#outputs-of-the-build-script for more information about build script outputs.
This doesn't change whether the fields are accessible outside the crate,
and avoids clippy warnings:
warning: scoped visibility modifier on a field
--> src/input/key_bindings.rs:44:2
|
44 | pub(crate) action_drop: Vec<Event>,
| ^^^^^^^^^^
|
= help: consider making the field private and adding a scoped visibility method for it
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_scoped_visibility_modifiers
It doesn't seem possible to disable the warning with an outer attribute, and using an inner attribute would cause inconsistent linting across files. Just disable the warning everywhere; presumably when we exclude code from test builds we do it intentionally. https://rust-lang.github.io/rust-clippy/master/index.html#cfg_not_test
Upstream breaking change: `\n` is now treated as width 1.
|
CI is clean; ready for review. |
|
Hey @bgilbert , thank you for all the effort that you've put into this pull request, as well as the other pull requests you've put up. Sadly, some of the changes I've made recently conflict with some of the work you've done. My plan is to cherry-pick over several of your changes over the next little while, since multiple of your changes are still very valid. |
|
No problem! I have some experience with maintainer burnout too, and you should do whatever is needed for your own health and, only after that, for the health of the project. Thanks for building and maintaining GIRT! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform semver-incompatible dependency updates of captur, claims, crossterm, git2, unicode-width, and version-track. unicode-width now treats
\nas having width 1.Disable compiler warning for Rust 2021
exprfragment specifiers. A manual audit of the existingexprspecifiers didn't turn up any problems with just switching to the 2024 semantics.Fix clippy warnings. Set MSRV to avoid more clippy warnings. Reformat with latest Rust nightly.