Proxy fixes #2490
Open
Proxy fixes #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erify download, fix upstream proxy function
Saml group mapping
Fix proxy in Jadx download, fix proxy in app func, fix frida server v…
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
added 2 commits
February 7, 2025 01:03
ajinabraham
requested changes
Mar 23, 2025
| @@ -73,6 +73,12 @@ services: | |||
| - POSTGRES_HOST=postgres | |||
| - POSTGRES_PORT=5432 | |||
| - MOBSF_ASYNC_ANALYSIS=1 | |||
| #Proxy options - use it if you behind proxy | |||
There was a problem hiding this comment.
Can you revert this rename?
| opener = build_opener(proxy_handler, https_handler) | ||
| install_opener(opener) | ||
| try: | ||
| with opener.open(Request(PLAYSTORE), timeout=5) as response: |
There was a problem hiding this comment.
Probably cleaner to replace this urllib implementation with requests as elsewhere.
There was a problem hiding this comment.
Use settings.PLAYSTORE instead.
| try: | ||
| with opener.open(Request(PLAYSTORE), timeout=5) as response: | ||
| if response.status == 200: | ||
| det = app(package_id) |
There was a problem hiding this comment.
nit: Add a comment that play store details is fetched only if playstore is reachable.
|
|
||
| from django.conf import settings | ||
| from mobsf.MobSF.settings import PLAYSTORE |
There was a problem hiding this comment.
We could use settings.PLAYSTORE
| @@ -0,0 +1,68 @@ | |||
| import os | |||
There was a problem hiding this comment.
Rename this file as upstream_proxy.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Pull Request
Checklist for PR
tox -e lint,testStaticAnalyzer/tests.py)Additional Comments (if any)