Fix CAPI #343
Merged
Fix CAPI #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- renamed `InterpTuples` to `InterpInfo` and named members like `Interp` - made members of `InterpInfo` public - reordered parameters of `pineappl_grid_new2` to have the same ordering as `Grid::new` - added new parameter `interpolations` that counts the number of interpolations, which in general is different from the number of convolutions plus one (previous assumption) - removed `nb_convolutions`, which can be inferred from the channels
|
Hi @cschwan, the main issue here which regards the ability to have more scales as provided by |
|
Looks good to me! Add your email to the CAPI's |
Thanks!! I'll merge once the tests are finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.