-
Notifications
You must be signed in to change notification settings - Fork 471
docs(fix): replace img tag with Markdown images #1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation preview |
@Pouyanpi , PTAL at the pyproject.toml and lock file updates. If the changes concern you, PLMK. TY, as always! |
We have 2 options:
I have also faced some issues with poetry version mismatch and my 2 latest PRs are failing. |
or even a third option if possible:
|
c254686
to
21a3406
Compare
I moved the deps update into #1090 using poetry 1.8.2. No objection from me, it was strained to do it in this PR. |
@mikemckiernan Is following OK? I mean does it only happen on Github? |
21a3406
to
5cbbefc
Compare
Signed-off-by: Mike McKiernan <[email protected]>
5cbbefc
to
71438e9
Compare
Ugh. No. I misunderstood the MyST Parser syntax. I pushed an update that uses an image directive. TY! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank You Mike and apologies for getting back to it now 👍🏻
Description
The img HTML tags do not communicate to Sphinx to copy the graphic to the output HTML. As a result, all the images were missing.
Review HTML: https://nvidia.github.io/NeMo-Guardrails/review/pr-1087/user-guides/guardrails-process.html
Related Issue(s)
Checklist