feat: implement validation to forbid dialog rails with reasoning traces #1137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a validator to ensure that reasoning traces cannot be enabled when dialog rails are present. The validator checks for both explicit dialog rails configuration and implicit dialog rails enabled through user messages, bot messages, and flows.
Impact
This change ensures that:
Changes
Added
check_reasoning_traces_with_dialog_rails
validator toRailsConfig
class that:rails.dialog
user_messages
bot_messages
flows
ValueError
if reasoning traces are enabled while dialog rails are presentAdded test cases in
test_config_validation.py
to verify:Testing
Added comprehensive test coverage:
Technical Details
The validator is implemented as a root validator in the
RailsConfig
class that (must migrated as part of #967:Breaking Changes
None. This is a new validation that prevents invalid configurations while it maintains backward compatibility
TODO: