Allow k8s-device-plugin daemonset run in nonpriveleged mode #1423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curlup
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this NVIDIA/k8s-device-plugin#435 (comment) limiting device plugin to be able to expose only certain devices.
With this change one can:
NVIDIA_VISIBLE_DEVICES=...in valuesunprivileged: truehave a device plugin only expose needed GPUs to allow for k8s not to schedule pods to certain GPUs.
The configuration is tested by me in our cluster but the comment with the workaround I mentioned seems to be somewhat widely referred to (and I assume adopted).
Obviously I'm new in this repo - let me know what else I can do to push this forward.