Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes DeprecationWarning introduced in setuptools>=77 #837

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

peterdsharpe
Copy link
Collaborator

@peterdsharpe peterdsharpe commented Apr 3, 2025

PhysicsNeMo Pull Request

Description

When installing PhysicsNeMo from source with setuptools>=77 (current latest release is v78), the following deprecation warning is emitted during install, from PhysicsNeMo:

      SetuptoolsDeprecationWarning: `project.license` as a TOML table is deprecated
      !!

              ********************************************************************************
              Please use a simple string containing a SPDX expression for `project.license`. You can also
      use `project.license-files`. (Both options available on setuptools>=77.0.0).

              By 2026-Feb-18, you need to update your project and remove deprecated calls
              or your builds will no longer be supported.

              See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for
      details.
              ********************************************************************************

      !!

This originates from pyproject.toml, which previously contained:

license = {text = "Apache 2.0"}

and should now be the following SPDX-compatible identifier:

license = "Apache-2.0"

Related:

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • [N/A] The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@peterdsharpe peterdsharpe self-assigned this Apr 3, 2025
@peterdsharpe
Copy link
Collaborator Author

/blossom-ci

@peterdsharpe peterdsharpe marked this pull request as ready for review April 3, 2025 22:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

pyproject.toml:30

  • The license classifier was removed; please verify that this change is intentional to ensure that package metadata remains correct for indexing on PyPI.
"License :: OSI Approved :: Apache Software License",

Copy link
Collaborator

@ktangsali ktangsali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the detailed description section :)

@peterdsharpe peterdsharpe merged commit 66fcfff into main Apr 8, 2025
1 check passed
@peterdsharpe peterdsharpe deleted the psharpe/fix-setuptools-deprecation branch April 8, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants