Skip to content

Enhanced Finder with item_type hints and specialized picker support #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Aitai
Copy link
Contributor

@Aitai Aitai commented Jun 4, 2025

This PR implements the enhanced Finder architecture discussed in #1748, adding item_type hints that enable specialized picker providers while maintaining fallback compatibility.

Key changes:

  • Added item_type support to Finder (branch, commit, tag, any_ref, stash, file)
  • Created fzf-lua provider with specialized pickers (git_branches, git_commits, git_tags, git_status, etc.)
  • Refactored diff popup with discoverable range actions (Branch Range, Commit Range, Tag Range) plus flexible Custom Range
  • Auto-populates entries based on item_type when none provided
  • Maintains intelligent fallback to generic pickers when specialized ones unavailable

This provides the hybrid UI approach discussed: common operations are discoverable while power-user scenarios (like diffing CHERRY_PICK_HEAD against a tag) are handled by the flexible Custom Range action using any_ref item_type.

Closes #1748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant