Skip to content

Update micromed for sampling issue #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zm711
Copy link
Contributor

@zm711 zm711 commented May 7, 2025

See #1696.

Testing to see if there is something wrong with class based approach @samuelgarcia maybe we could discuss this.

@zm711 zm711 changed the title Update micromed for samping issue Update micromed for sampling issue May 7, 2025
@zm711
Copy link
Contributor Author

zm711 commented May 7, 2025

@theairbend3r
could you test this PR? I just want to see what happens if we try removing the class approach we used before (ie your suggestion and what wonambi was doing). Our tests are passing for micromed so this could be a fix we make if it works for you :)

@theairbend3r
Copy link
Contributor

Tried this out but I still get the same ZeroDivisionError unfortunately

@zm711
Copy link
Contributor Author

zm711 commented May 8, 2025

Okay, I was hoping this would be the easy fix, but when I have time I'll try to read wonami more to see if they are doing some header parsing that we skip that could better account for different versions of the file format.

@theairbend3r
Copy link
Contributor

Sounds good! Thanks for all your efforts, really appreciate it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants