Skip to content

Add Lenovo ThinkPad P14s Intel Gen 2 #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

borja-rojo-ilvento
Copy link

Description of changes

Added a configuration for the Lenovo ThinkPad P14s Gen 2 (which is my current daily driver). Seems it just needed a PCI bus adjustment. It uses an NVidia T500 and Intel Xe graphics. It mimics the implementations for the Gen 3 and Gen 5 models otherwise.

Things done
  • Tested the changes in your own NixOS Configuration

  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

  • Ran nix run ./tests#run . and passes

@borja-rojo-ilvento borja-rojo-ilvento marked this pull request as draft June 20, 2025 23:37
@borja-rojo-ilvento
Copy link
Author

Found the issue. It was an omission of the common/gpu/intel/tiger-lake module, which I believe will include the relevant media drivers.

@borja-rojo-ilvento borja-rojo-ilvento marked this pull request as ready for review June 22, 2025 21:36
@borja-rojo-ilvento
Copy link
Author

@mergify queue

Copy link
Contributor

mergify bot commented Jun 22, 2025

queue

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission >= write

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant