-
-
Notifications
You must be signed in to change notification settings - Fork 756
Add Lenovo ThinkPad P14s Intel Gen 2 #1509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
borja-rojo-ilvento
wants to merge
18
commits into
NixOS:master
Choose a base branch
from
borja-rojo-ilvento:lenovo-thinkpad-p14s-intel-gen2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Lenovo ThinkPad P14s Intel Gen 2 #1509
borja-rojo-ilvento
wants to merge
18
commits into
NixOS:master
from
borja-rojo-ilvento:lenovo-thinkpad-p14s-intel-gen2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y are more complete for handling the powermanagement settings with PRIME sync.
…powermangerment off for now.
…Finegrained is disabled. Modesetting is enabled, as per the wiki.
…. Seems to persist.
This reverts commit 74787b1.
Found the issue. It was an omission of the |
@mergify queue |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added a configuration for the Lenovo ThinkPad P14s Gen 2 (which is my current daily driver). Seems it just needed a PCI bus adjustment. It uses an NVidia T500 and Intel Xe graphics. It mimics the implementations for the Gen 3 and Gen 5 models otherwise.
Things done
Tested the changes in your own NixOS Configuration
Tested the changes end-to-end by using your fork of
nixos-hardware
andimporting it via
<nixos-hardware>
or Flake inputRan
nix run ./tests#run .
and passes