Skip to content

Fetch commit date instead of last eval time #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PerchunPak
Copy link
Member

@PerchunPak PerchunPak commented Dec 27, 2024

This fixes the bug where status.nixos.org would show the date of the last successes eval instead of the more informative commit date.

Current status.nixos.org:
image

After this change:
image

@PerchunPak PerchunPak marked this pull request as ready for review December 28, 2024 11:38
@PerchunPak PerchunPak changed the title WIP fetch commit date instead of last eval time Fetch commit date instead of last eval time Dec 28, 2024
@collares
Copy link
Member

collares commented Dec 31, 2024

The current timestamp in status.nixos.org is when the channel last advanced, right? To me, that fits the "Last updated" header better than the timestamp of the corresponding commit (which is easily obtained by clicking the commit SHA). Is there another place which currently displays when a channel last advanced?

@adamcstephens
Copy link

Why not add a second column for commit age?

@vcunat
Copy link
Member

vcunat commented Dec 31, 2024

To me personally stamp of the channel commit is much more useful than "last updated" stamp. (Ideally I'd want to see the push stamp of the next commit after the channel, but that would be too complex I guess.)

@vcunat
Copy link
Member

vcunat commented Dec 31, 2024

This had been discussed e.g. on #7

@PerchunPak
Copy link
Member Author

I'm unsure what was 5 years ago, but currently all channel heads are merge commits that have a timestamp, when a PR was merged. AFAIK, no one has direct push access to nixpkgs and so the update time must be accurate.

Please see this discussion for more context
https://matrix.to/#/!kjdutkOsheZdjqYmqp:nixos.org/$aG-TWSnYNDd-SDqP7mgPg0ReBT8svudHFkJUOlAkVWY?via=nixos.org&via=matrix.org&via=tchncs.de

@vcunat
Copy link
Member

vcunat commented Dec 31, 2024

Right. Some direct pushes were there at that point, but commit time is normally refreshed on any cherry-pick or rebase, so I don't think this aspect makes a big difference. (I think most were merges, too.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants