Skip to content

Upgrade to Sentry 9.6.1 + Client side setup #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

antico5
Copy link
Collaborator

@antico5 antico5 commented Mar 21, 2025

  • Removed deprecated packages: sentry/tracing and sentry/types

  • Updated sentry/node to latest version, 9.6.1

  • Added sentry/core, which is a transient dependency of sentry/node since some functions and types are not re-exported by sentry/node

  • Some concepts ceased to exist, for instance Transactions. So I migrated to the new approach which is to use only spans (top level spans are what transactions used to be)

  • Some methods e.g. setTag now should be invoked directly from Sentry, so our application is a bit more coupled to sentry instead of the abstract Telemetry class. I think it's unnecesary to have such abstraction, and would get rid of it. If we wanted to completely decouple from Sentry it'd be too much overhead for little benefit

  • New custom client side setup to avoid global extension host context

  • Global uncaughtError + unhandledRejection handlers on client process, with a filter on stack traces

  • Capture and report as handled errors on every execution path on the client side

  • Since we have to manually call captureException on unhandled errors, they are not marked as "unhandled" by sentry, so I added an additional tag isHandled, for client side events

@antico5 antico5 requested a review from kanej March 21, 2025 14:48
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Mar 21, 2025
@antico5 antico5 changed the title Upgrade to Sentry 9.6.1 WIP - Upgrade to Sentry 9.6.1 Mar 21, 2025
Copy link

socket-security bot commented Mar 21, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@sentry/[email protected], 7.32.19.6.1 None 0 0 B
npm/@sentry/[email protected]9.6.1 Transitive: shell, unsafe +47 20.4 MB

🚮 Removed packages: npm/@sentry/[email protected], npm/@sentry/[email protected]

View full report↗︎

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 31.11111% with 93 lines in your changes missing coverage. Please review.

Project coverage is 54.95%. Comparing base (076c399) to head (702ca0e).

Files with missing lines Patch % Lines
server/src/services/validation/validate.ts 18.18% 24 Missing and 3 partials ⚠️
...er/src/services/documentSymbol/onDocumentSymbol.ts 7.69% 24 Missing ⚠️
...er/src/services/formatting/onDocumentFormatting.ts 11.76% 15 Missing ⚠️
...c/services/initialization/indexWorkspaceFolders.ts 9.09% 10 Missing ⚠️
...services/semanticHighlight/onSemanticTokensFull.ts 22.22% 7 Missing ⚠️
server/src/services/completion/onCompletion.ts 75.00% 2 Missing and 1 partial ⚠️
server/src/services/codeactions/onCodeAction.ts 33.33% 2 Missing ⚠️
server/src/services/validation/analyse.ts 66.66% 2 Missing ⚠️
server/src/telemetry/tags.ts 60.00% 1 Missing and 1 partial ⚠️
server/src/utils/onCommand.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #654      +/-   ##
===============================================
+ Coverage        54.71%   54.95%   +0.24%     
===============================================
  Files              227      227              
  Lines             5253     5259       +6     
  Branches           812      812              
===============================================
+ Hits              2874     2890      +16     
+ Misses            2139     2128      -11     
- Partials           240      241       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@antico5 antico5 force-pushed the update_sentry_9 branch 3 times, most recently from bcf535c to 8fc75e1 Compare April 8, 2025 17:27
@antico5 antico5 changed the title WIP - Upgrade to Sentry 9.6.1 Upgrade to Sentry 9.6.1 + Client side setup Apr 8, 2025
@antico5
Copy link
Collaborator Author

antico5 commented Apr 8, 2025

@kanej ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant