Skip to content

languages/qml: add QML support #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TheSunCat
Copy link
Contributor

This merge request adds support for the qmlls LSP and qmlformat formatter in nvf, toggleable with languages.qml options. The implementation is largely based off of the clang.nix (LSP) and svelte.nix (formatter) files, as I am still new-ish to the Nix language, but I think most of the code makes sense.

Note that qmlls requires passing the -E argument to have it read the QML2_IMPORT_PATH environment variable, which is required for the ability to import QML modules on NixOS (they are installed in the Nix store).

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@TheSunCat TheSunCat requested a review from NotAShelf as a code owner March 1, 2025 14:19
github-actions bot pushed a commit that referenced this pull request Mar 1, 2025
Copy link

github-actions bot commented Mar 1, 2025

🚀 Live preview deployed from 851dbc9

View it here:

Debug Information

Triggered by: TheSunCat

HEAD at: feat-languages-qml

Reruns: 652

horriblename
horriblename previously approved these changes Mar 1, 2025
@NotAShelf NotAShelf force-pushed the main branch 5 times, most recently from 02ee4cc to bc978c4 Compare March 17, 2025 11:42
@TheSunCat TheSunCat requested a review from Soliprem as a code owner April 7, 2025 21:34
github-actions bot pushed a commit that referenced this pull request Apr 7, 2025
@TheSunCat
Copy link
Contributor Author

I feel like that did the wrong thing but I'll just trust github's web workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants