-
Notifications
You must be signed in to change notification settings - Fork 92
Decompressed Stream Support #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
21b63e1
to
7faf317
Compare
r? @Nemo157 |
and a bit of refactoring adding the bytes
Overall looks good, just a couple of small issues in the flate compression. |
@Nemo157 I think I'm ready for another review. EDIT: Well, I could write more tests, actually (and probably ones that don't depend on implementations native to this crate), but I'll ask more about them later. |
decompressed gzip currently breaks somewhere -- will figure this out
I believe I know how to refactor this, but might need a bit help
A remark on using The only time(s) this is reached is when the input is too small be read as data, as the footer will always take up 8 bytes, and the check here: Prevents the footer from being read as data. So I think this is the best I can get it without it freaking out on any odd/malformed data. Let's go with one more review, and I think this should be good? @Nemo157 |
Oh right, I forgot the inner stream can be pending. I'll fix it up right now. |
Awesome, now I'll rebase the proptest branch on this and see if I can break it 😈 |
Description
This PR seeks to add support for decompressing streams of encoded bytes under each of the encoding algorithms used.
This is the current progress:
Motivation and Context
Coming up with a standard pattern of decompressing encoded streams that the library already provides would be valuable for various use cases.
It would also unblock progress on http-rs/tide#194.
How Has This Been Tested?
Tests are added.
Types of changes
Checklist: