Skip to content

Experimental: Recycle SslStreamCertificateContext objects for client and server #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

borland
Copy link
Contributor

@borland borland commented Feb 26, 2025

Are you a customer of Octopus Deploy? Please contact our support team so we can triage your PR, so that we can make sure it's handled appropriately.

Background

dotnet/runtime#110803 (comment)

Results

When running Halibut on .NET 9, we appear to be affected by the memory leak detailed in dotnet/runtime#110803. This says it will be fixed in .NET 10, but there is significant time until that is available.

I experimented with DOTNET_SYSTEM_NET_SECURITY_DISABLETLSRESUME=1 as a workaround, and while it helps reduce the rate of memory leaking, it does not solve it.

This PR implements the second proposed solution, which is to refactor our code to share an SslStreamCertificateContext across connections.

Note: We do not handle the SslStreamCertificateContext object directly, but rather take the second path and recycle the SslServerAuthenticationOptions object which owns the certificate context.

Also

While the github issue only describes a memory leak when dealing with a server-side stream, SslStreamCertificateContext is also employed on the client side since it was added into SslClientAuthenticationOptions in dotnet 8

If the certificate context leaks an OpenSSL handle when used for server auth, it seems reasonable that it could also leak when used for client auth. So this PR also reuses SslClientAuthenticationOptions by way of a cache, to see if that helps.

How to review this PR

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

@borland borland requested a review from a team as a code owner February 26, 2025 21:51
@borland borland marked this pull request as draft February 26, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant