refactor: use getTransferMode instead of isDepositMode #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fionnachan
commented
Jan 16, 2025
Comment on lines
17
to
19
| if (!validDestinationChains.includes(destinationChainId)) { | ||
| throw new Error('Unsupported source and destination chain pair.') | ||
| } |
There was a problem hiding this comment.
remove throw and return false instead
fionnachan
commented
Jan 16, 2025
| import { isDepositMode } from './isDepositMode' | ||
| import { getDestinationChainIds } from './networks' | ||
|
|
||
| type TransferMode = 'deposit' | 'withdrawal' | 'teleport' |
There was a problem hiding this comment.
Suggested change
| type TransferMode = 'deposit' | 'withdrawal' | 'teleport' | |
| type TransferMode = 'deposit' | 'withdrawal' | 'teleport' | 'unsupported' |
chrstph-dvx
reviewed
Jan 20, 2025
packages/arb-token-bridge-ui/src/components/TransferPanel/EstimatedGas.tsx
Outdated
Show resolved
Hide resolved
packages/arb-token-bridge-ui/src/util/__tests__/getTransferMode.test.ts
Outdated
Show resolved
Hide resolved
packages/arb-token-bridge-ui/src/hooks/TransferPanel/useGasSummary.ts
Outdated
Show resolved
Hide resolved
packages/arb-token-bridge-ui/src/components/TransferPanel/useTransferReadiness.ts
Show resolved
Hide resolved
...arb-token-bridge-ui/src/components/TransferPanel/TransferPanelMain/DestinationNetworkBox.tsx
Show resolved
Hide resolved
...arb-token-bridge-ui/src/components/TransferPanel/TransferPanelMain/DestinationNetworkBox.tsx
Show resolved
Hide resolved
brtkx
previously approved these changes
Jan 21, 2025
chrstph-dvx
previously approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
trying out inline union checks and getting rid of boolean helpers to see how it feels