-
Notifications
You must be signed in to change notification settings - Fork 266
[Outlook] (event-based activation) Refresh content #5227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Learn Build status updates of commit d6e02bc: ✅ Validation status: passed
For more details, please refer to the build report. |
Learn Build status updates of commit b940db2: ✅ Validation status: passed
For more details, please refer to the build report. |
Learn Build status updates of commit b178cb6: ✅ Validation status: passed
For more details, please refer to the build report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refreshes content for Outlook event‐based activation by surfacing mobile device support, reorganizing sample and walkthrough content, and clarifying the use of the Office.actions.associate method. Key changes include:
- Adding a new TOC entry and dedicated section for event‐based activation on Outlook mobile devices.
- Updating documentation dates and clarifying notes regarding event handler mapping.
- Enhancing tables and note sections across various walkthrough files to reflect mobile support and version updates.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
docs/toc.yml | Added mobile-specific TOC entry for event-based activation support. |
docs/outlook/smart-alerts-onmessagesend-walkthrough.md | Updated ms.date and enhanced note regarding Office.actions.associate usage. |
docs/outlook/outlook-mobile-apis.md | Updated ms.date and added a new “Supported events” section with version details. |
docs/outlook/onmessagefromchanged-onappointmentfromchanged-events.md | Updated ms.date and refined note formatting for clarity on event handler mapping. |
docs/outlook/on-new-compose-events-walkthrough.md | Updated ms.date and added a note about mobile support for OnNewMessageCompose. |
docs/outlook/mobile-event-based.md | Updated ms.date and revised event version details in the API table. |
docs/outlook/autolaunch.md | Updated ms.date, restructured note sections, and introduced new sections for mobile add-in activation. |
Comments suppressed due to low confidence (4)
docs/outlook/outlook-mobile-apis.md:32
- [nitpick] Ensure that the newly added 'Supported events' section accurately reflects the API version details and is consistent with other mobile documentation sections.
## Supported events
docs/outlook/onmessagefromchanged-onappointmentfromchanged-events.md:382
- [nitpick] Align the note block formatting with other documentation sections to maintain consistency in style; consider whether all bullet points are required to avoid potential redundancy.
+> - In classic Outlook on Windows, imports aren't supported in the JavaScript file where you implement the handling for event-based activation.
docs/outlook/on-new-compose-events-walkthrough.md:18
- [nitpick] Verify that this new note clearly complements the existing content without repeating information that is provided later in the document.
The `OnNewMessageCompose` event is now supported in Outlook on mobile devices. To learn how to implement this event in your Outlook mobile add-in, see [Implement event-based activation in Outlook mobile add-ins](mobile-event-based.md).
docs/outlook/autolaunch.md:44
- [nitpick] Review the wording in this note to ensure it fully reflects the updated mobile activation changes and avoids potential confusion when read alongside the newly added 'Event-based activation in Outlook mobile devices' section.
> <sup>2</sup> For more information, see [Implement event-based activation in Outlook mobile add-ins](mobile-event-based.md).
> Event-based add-ins running in classic Outlook on Windows don't run code included in the `Office.onReady()` and `Office.initialize` functions. We recommend adding your add-in startup logic, such as checking the user's Outlook version, to your event handlers instead. | ||
> | ||
> - In classic Outlook on Windows, imports aren't supported in the JavaScript file where you implement the handling for event-based activation. | ||
> - Event-based add-ins running in classic Outlook on Windows don't run code included in the `Office.onReady()` and `Office.initialize` functions. We recommend adding your add-in startup logic, such as checking the user's Outlook version, to your event handlers instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can add-ins implement event-based activation as well as other features? If so, could that mean that if the dev does initialization only in the event handlers, then other functionality won't have been initialized?
> - Event-based add-ins running in classic Outlook on Windows don't run code included in the `Office.onReady()` and `Office.initialize` functions. We recommend adding your add-in startup logic, such as checking the user's Outlook version, to your event handlers instead. | |
> - Event-based add-ins running in classic Outlook on Windows don't run code included in the `Office.onReady()` and `Office.initialize` functions. We recommend adding your add-in startup logic, such as checking the user's Outlook version, to your event handlers as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great questions. Startup logic in the initialization method that pertains to non-event handler code will run. There are other articles not related to event-based activation that will also need to be updated, so I'll address this in a separate PR.
Co-authored-by: Elizabeth Samuel <[email protected]>
Learn Build status updates of commit cdff21a: ✅ Validation status: passed
For more details, please refer to the build report. |
associate
method in applicable event-based walkthroughs.