Skip to content

[Excel] (Custom functions) Add custom enums article #5252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 27, 2025

Conversation

alison-mk
Copy link
Contributor

@alison-mk alison-mk commented Jun 25, 2025

Note that the related JSDoc and metadata reference articles are updated in separate PR: #5240

Copy link
Contributor

Learn Build status updates of commit 949aa09:

✅ Validation status: passed

File Status Preview URL Details
docs/excel/custom-functions-custom-enums.md ✅Succeeded View
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

Copy link
Contributor

Learn Build status updates of commit 2225d74:

✅ Validation status: passed

File Status Preview URL Details
docs/excel/custom-functions-custom-enums.md ✅Succeeded View
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

Copy link
Contributor

Learn Build status updates of commit 2c1e25b:

💡 Validation status: suggestions

File Status Preview URL Details
docs/images/custom-functions-custom-enum-autocomplete.png 💡Suggestion View Details
docs/excel/custom-functions-custom-enums.md ✅Succeeded View
docs/toc.yml ✅Succeeded View

docs/images/custom-functions-custom-enum-autocomplete.png

  • Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation] The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@alison-mk alison-mk marked this pull request as ready for review June 26, 2025 01:46
@alison-mk alison-mk requested a review from Copilot June 26, 2025 01:46
Copilot

This comment was marked as outdated.

Copy link
Contributor

Learn Build status updates of commit c2e82be:

💡 Validation status: suggestions

File Status Preview URL Details
docs/images/custom-functions-custom-enum-autocomplete.png 💡Suggestion View Details
docs/excel/custom-functions-custom-enums.md ✅Succeeded View
docs/toc.yml ✅Succeeded View

docs/images/custom-functions-custom-enum-autocomplete.png

  • Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation] The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

Copy link
Contributor

Learn Build status updates of commit f59304d:

💡 Validation status: suggestions

File Status Preview URL Details
docs/images/custom-functions-custom-enum-autocomplete.png 💡Suggestion View Details
docs/excel/custom-functions-custom-enums.md ✅Succeeded View
docs/toc.yml ✅Succeeded View

docs/images/custom-functions-custom-enum-autocomplete.png

  • Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation] The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@alison-mk alison-mk requested a review from AlexJerabek June 26, 2025 01:52
Copy link
Collaborator

@AlexJerabek AlexJerabek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a couple suggestions.

}
```

## Edit enums in JSON metadata
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this section be in the "Manually create JSON metadata for custom functions" article instead? I think that would help keep this article simple and help the common use case of people just using TypeScript.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll move it. Thanks for the feedback!

Copy link
Contributor

Learn Build status updates of commit f298cda:

💡 Validation status: suggestions

File Status Preview URL Details
docs/images/custom-functions-custom-enum-autocomplete.png 💡Suggestion View Details
docs/excel/custom-functions-custom-enums.md ✅Succeeded View
docs/toc.yml ✅Succeeded View

docs/images/custom-functions-custom-enum-autocomplete.png

  • Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation] The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

Copy link
Contributor

Learn Build status updates of commit f5e4ec1:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/excel/custom-functions-custom-enums.md ⚠️Warning View Details
docs/images/custom-functions-custom-enum-autocomplete.png 💡Suggestion View Details
docs/toc.yml ✅Succeeded View

docs/excel/custom-functions-custom-enums.md

  • Line 19, Column 244: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#enums' in 'excel/custom-functions-json.md', did you mean '#result'?

docs/images/custom-functions-custom-enum-autocomplete.png

  • Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation] The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

Copy link
Contributor

Learn Build status updates of commit 0b2701c:

💡 Validation status: suggestions

File Status Preview URL Details
docs/images/custom-functions-custom-enum-autocomplete.png 💡Suggestion View Details
docs/excel/custom-functions-custom-enums.md ✅Succeeded View
docs/toc.yml ✅Succeeded View

docs/images/custom-functions-custom-enum-autocomplete.png

  • Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation] The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@alison-mk alison-mk requested a review from Copilot June 27, 2025 21:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new article on using custom enums in Excel custom functions and wires it into the documentation table of contents.

  • Adds a TOC entry for the new "Custom enums" topic under Excel custom functions
  • Introduces custom-functions-custom-enums.md, covering enum definition, reuse, localization, and compatibility

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
docs/toc.yml Inserted a new TOC item for the custom enums article
docs/excel/custom-functions-custom-enums.md New documentation on defining and using custom enums in TypeScript
Comments suppressed due to low confidence (2)

docs/toc.yml:680

  • [nitpick] TOC name entries use Title Case for consistency with other items; consider renaming to Custom Enums.
    - name: Custom enums

docs/excel/custom-functions-custom-enums.md:80

  • The @returns tag is empty; add a return type and description (e.g., @returns {string} A formatted sum string.).
* @returns


## Use a custom enum multiple times

An custom enum can be reused in multiple functions, and it can be used as multiple parameters of a single function. A function can also have multiple enums as parameters at the same time. An enum parameter can be repeating or optional.
Copy link
Preview

Copilot AI Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar: Change An custom enum to A custom enum.

Copilot uses AI. Check for mistakes.

Copy link
Contributor

Learn Build status updates of commit 82c2d98:

💡 Validation status: suggestions

File Status Preview URL Details
docs/images/custom-functions-custom-enum-autocomplete.png 💡Suggestion View Details
docs/excel/custom-functions-custom-enums.md ✅Succeeded View
docs/toc.yml ✅Succeeded View

docs/images/custom-functions-custom-enum-autocomplete.png

  • Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation] The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@alison-mk alison-mk merged commit 4d106e1 into main Jun 27, 2025
2 checks passed
@alison-mk alison-mk deleted the alison-mk-custom-enum branch June 27, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants