Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][elixir] use elixir 1.18 built-in json module #21039

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

efcasado
Copy link
Contributor

@efcasado efcasado commented Apr 5, 2025

Description

A potential implementation for #21038.

Curious to hear your thoughts, @mrmstn.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@efcasado efcasado changed the title [Elixir] Use Elixir 1.18 built-in JSON module [feat][elixir] use elixir 1.18 built-in json module Apr 6, 2025
@mrmstn
Copy link
Contributor

mrmstn commented Apr 6, 2025

Hi @efcasado,

Nice! Thanks for submitting this PR—it looks good to me. I just want to run a quick test tomorrow to ensure it's as straightforward as it looks like 😄 .

@wing328 — Regarding versioning, this change doesn't technically break the client's API but does introduce a dependency on Elixir 1.18. Given that earlier versions are already EOL, my feeling is that it's safe to merge into master. However, I'm open to your thoughts—what's your take?

@wing328
Copy link
Member

wing328 commented Apr 7, 2025

Given that earlier versions are already EOL, my feeling is that it's safe to merge into master. However, I'm open to your thoughts—what's your take?

sounds good to me too

users who need to use older versions of Elixir with the generated client can pin openapi generator to v7.12.0 without upgrading to newer versions that no longer support outdated Elixir versions

@mrmstn
Copy link
Contributor

mrmstn commented Apr 8, 2025

Just a quick update - looks like my nix environment still does not know elixir 1.18 - I'm currently figuring out on how to force the update since it's already available in 24.11 😅

Copy link
Contributor

@mrmstn mrmstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrmstn mrmstn merged commit dcd9463 into OpenAPITools:master Apr 8, 2025
15 checks passed
@mrmstn mrmstn added this to the 7.13.0 milestone Apr 8, 2025
@mrmstn mrmstn self-assigned this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants