Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes so that a oneOf schema with a single sub-schema is simplified #21043

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Mattias-Sehlstedt
Copy link
Contributor

@Mattias-Sehlstedt Mattias-Sehlstedt commented Apr 6, 2025

Fixes #21042

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Mattias-Sehlstedt Mattias-Sehlstedt force-pushed the normalize-one-of-with-single-ref branch from 519f329 to d1994f8 Compare April 6, 2025 14:12
@Mattias-Sehlstedt Mattias-Sehlstedt force-pushed the normalize-one-of-with-single-ref branch 2 times, most recently from c6fe76a to edcc106 Compare April 6, 2025 14:54
@Mattias-Sehlstedt Mattias-Sehlstedt force-pushed the normalize-one-of-with-single-ref branch from edcc106 to d69a929 Compare April 6, 2025 15:39
@Mattias-Sehlstedt
Copy link
Contributor Author

Mattias-Sehlstedt commented Apr 6, 2025

Would the project considered this as a breaking change due to how it might affect those that are currently using the incorrect single-oneOf behavior as an expected behavior? Or does a bugfix surpass that reasoning?

(If it is considered a breaking change, then I would love if this feature would be merged so that I could easily implement the fix locally)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant