Skip to content

[tools] Update template pr github #3037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: release/current
Choose a base branch
from

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Apr 24, 2025

Proposed changes

  • Add section: What should be tested and how?

Related issues

  • Closes #ISSUE-NUMBER

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Apr 24, 2025
@savacano28 savacano28 self-assigned this Apr 24, 2025
@savacano28 savacano28 changed the base branch from master to release/current April 24, 2025 16:33
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.02%. Comparing base (419b98d) to head (1aed7be).

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/current    #3037   +/-   ##
==================================================
  Coverage              41.02%   41.02%           
  Complexity              2274     2274           
==================================================
  Files                    681      681           
  Lines                  20908    20908           
  Branches                1422     1422           
==================================================
  Hits                    8577     8577           
  Misses                 11849    11849           
  Partials                 482      482           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@savacano28 savacano28 marked this pull request as ready for review April 24, 2025 16:45
@guillaumejparis
Copy link
Member

LGTM maybe wait for somebody with abeeter English than me to check it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants