-
Notifications
You must be signed in to change notification settings - Fork 117
Issue/2565 #3044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/2565 #3044
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/current #3044 +/- ##
=====================================================
- Coverage 41.27% 41.20% -0.07%
+ Complexity 2290 2286 -4
=====================================================
Files 682 682
Lines 20938 20938
Branches 1424 1424
=====================================================
- Hits 8642 8628 -14
- Misses 11810 11824 +14
Partials 486 486 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase so that the PR is scoped to the exact changes ?
It's a +2/-2 changeset so we shouldn't take the lockfile and deps changes.
Hello @antoinemzs, I do not understand is the fact that there is the renovate of ckeditor on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related issues