[PATCH v3] api: event: add event type metadata to event vectors #2217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
odpbuild
changed the title
|
v2: fixed misspelling of ODP_EVENT_ANY. |
Change odp_event_vector_type() to not return the type of events actually stored in the event vector but the event type stored in event vector metadata and add odp_event_vector_type_set() to set the event type. Specify that event aggregators try to set the event type according to the event types they put in the event vector and require that applications use odp_event_vector_type_set() to update the event type of a vector after vector table modifications. This way odp_event_vector_type() can be used largely as before, but an ODP implementation is not forced to loop through the vector every time odp_event_vector_type() is called. Signed-off-by: Janne Peltonen <[email protected]>
Implement event type metadata in event vectors. Signed-off-by: Janne Peltonen <[email protected]>
Modify the tests to use odp_event_vector_type_set() and to take the new semantics of odp_event_vector_type() into account. Signed-off-by: Janne Peltonen <[email protected]>
odpbuild
changed the title
|
v3:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change odp_event_vector_type() to not return the type of events actually stored in the event vector but the event type stored in event vector metadata and add odp_event_vector_type_set() to set the event type. Specify that event aggregators set the event type according to the event types they put in the event vector and require that applications use odp_event_vector_type_set() to update the event type of a vector after vector table modifications.
This way odp_event_vector_type() can be used largely as before, but an ODP implementation is not forced to loop through the vector every time odp_event_vector_type() is called.