-
Notifications
You must be signed in to change notification settings - Fork 18
Create deb and rpm automatically #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Just realized it should be packaged without being self-contained. |
When is the job supposed to run? It isn't part of the commit or tag actions. |
It runs when you push a tag that starts with v, just like the current release action is set up. |
I am just wondering, why not create the package every build? |
@samuel-w Notifying you again in case you missed the last message |
- name: Checkout | ||
uses: actions/checkout@v3 | ||
- name: Setup .NET Core SDK | ||
uses: actions/setup-dotnet@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses: actions/setup-dotnet@v3 | |
uses: actions/setup-dotnet@v4 |
src/openlauncher/bin/Release/net7.0/${{ matrix.rid }}/publish/openlauncher.exe | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses: actions/checkout@v3 | |
uses: actions/checkout@v4 |
@@ -17,9 +19,9 @@ jobs: | |||
- name: Checkout | |||
uses: actions/checkout@v3 | |||
- name: Setup .NET Core SDK | |||
uses: actions/setup-dotnet@v1 | |||
uses: actions/setup-dotnet@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses: actions/setup-dotnet@v3 | |
uses: actions/setup-dotnet@v4 |
path: src/openlauncher/bin/Release/net7.0/${{ matrix.rid }}/publish/**/* | ||
- name: Create release | ||
uses: softprops/action-gh-release@v1 | ||
path: src/openlauncher/bin/Release/net${{ env.dotnet-version }}/${{ matrix.rid }}/publish/**/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
path: src/openlauncher/bin/Release/net${{ env.dotnet-version }}/${{ matrix.rid }}/publish/**/* | |
path: src/openlauncher/bin/Release/net${{ env.dotnet-version }}/${{ matrix.rid }}/publish/**/* | |
if-no-files-found: error |
with: | ||
merge-multiple: true | ||
path: artifacts/ | ||
- uses: softprops/action-gh-release@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- uses: softprops/action-gh-release@v1 | |
- uses: softprops/action-gh-release@v2 |
This PR seems abandoned, but also quite useful. I may take it over once time allows (though that may still be a bit in the future). If anyone else feels like taking it over, please say so. |
Also fixed the test (which can get rate limited somehow even though it's on GitHub's servers, but shouldn't happen to users unless they spam-click the buttons) and bumped action versions
https://github.com/samuel-w/OpenLauncher/releases/tag/v0.3.2
Closes #24