Updated SignatureChecker NatSpec to better reflect EIP-7702 behavior
#5670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzaotc
changed the title
SignatureChecker NatSpectto better reflect ERC-7702 behavior
gonzaotc
changed the title
SignatureChecker NatSpectto better reflect ERC-7702 behaviorSignatureChecker NatSpec to better reflect ERC-7702 behavior
gonzaotc
changed the title
SignatureChecker NatSpec to better reflect ERC-7702 behaviorSignatureChecker NatSpec to better reflect EIP-7702 behavior
arr00
reviewed
May 7, 2025
| * @dev Checks if a signature is valid for a given signer and data hash. If the signer is a smart contract, the | ||
| * signature is validated against that smart contract using ERC-1271, otherwise it's validated using `ECDSA.recover`. | ||
| * @dev Checks if a signature is valid for a given signer and data hash. If the signer has code, the | ||
| * signature is validated against it using ERC-1271, otherwise it's validated using `ECDSA.recover`. | ||
| * | ||
| * NOTE: Unlike ECDSA signatures, contract signatures are revocable, and the outcome of this function can thus |
There was a problem hiding this comment.
Suggested change
| * NOTE: Unlike ECDSA signatures, contract signatures are revocable, and the outcome of this function can thus | |
| * NOTE: Unlike ECDSA signatures, ERC-1271 signatures are revocable, and the outcome of this function can thus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As already acknowledged in PR #4951 and issue #4855,
SignatureChecker.isValidSignatureNowvalidates signatures viaERC-1271instead ofECDSA recoverfor any signer that has code. This is enforced by design and the justification can found in the mentioned issue.This NatSpec slight change has the objective of making it more explicit in the context of EIP-7702 EOA's delegations, where the EOA get's Smart Contract code associated, and therefore
ERC-1271verifications apply.