remove panic handlers #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qalisander
force-pushed
the
remove-panic-handlers
branch
from
85b8dda to
afc7b59
Compare
qalisander
force-pushed
the
remove-panic-handlers
branch
from
afc7b59 to
46bf0f1
Compare
qalisander
commented
Oct 23, 2024
| @@ -25,7 +25,7 @@ jobs: | |||
| with: | |||
| target: wasm32-unknown-unknown | |||
| components: rust-src | |||
| toolchain: nightly-2024-01-01 | |||
| toolchain: nightly-2024-07-25 | |||
There was a problem hiding this comment.
cargo-stylus refused to compile on nightly-2024-01-01 this time. There won't be a problem, when we will merge these changes after pr with nightly fix
qalisander
commented
Oct 23, 2024
| @@ -1,4 +1,4 @@ | |||
| #![cfg_attr(not(test), no_main, no_std)] | |||
There was a problem hiding this comment.
As an option library user can add #[no_std] and have a #[panic_handler] in his contract.
For simplicity we can just opt out #[no_std] in examples.
There was a problem hiding this comment.
Also I've noticed zero difference in terms of wasm size of example with #[no_std] and without it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.